Flatten enums in claude message serialization #10831
Draft
+778
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
rust
mtsgrd
commented
Oct 29, 2025
crates/but-claude/src/db.rs
Outdated
Comment on lines
144
to
157
| .filter_map(|m| { | ||
| let message_id = m.id.clone(); | ||
| match m.try_into() { | ||
| Ok(msg) => Some(msg), | ||
| Err(e) => { | ||
| tracing::warn!( | ||
| message_id = %message_id, | ||
| error = %e, | ||
| "Failed to deserialize claude message, skipping" | ||
| ); | ||
| None | ||
| } | ||
| } | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
@krlvi fyi - about ignoring read errors for list_messages_by_session
Instead of `{type: 'claudeOutput', subject: {..}}` this code now
serializes messages into `{claudeOutput: {..}}`. This is the default
format for `serde`, as well as protobuf and thrift.
Additionally, since these structs get serialized and stored on disk, we
have to allow errors to happen on read so that we have a chance to
modify the data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
{type: 'claudeOutput', subject: {..}}this code now serializes messages into{claudeOutput: {..}}. This is the default format forserde, as well as protobuf and thrift.Additionally, since these structs get serialized and stored on disk, we have to allow errors to happen on read so that we have a chance to modify the data structures.